Add action schema to track wallet and stake events #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejearley
approved these changes
Jul 20, 2023
|
Yes lets keep the output bucket so the client (whoever callsAthena) can set the query output to that bucket. That works for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the wallet schema and replaced it with
action.schema.jsonto hold the wallet and stake events per our online discussions with @elizyoung0011. Updated CDK analytics script to create the required buckets and tablesI added a
$commentfield to the analytics schema files. That will make it easier for me to do code gen only on those files.There is an output bucket but I don't think we are currently using it as the output location of the Athena queries. It is easy to set the output location in the console but I couldn't find a
outputLocationor a similar option to pass it to thenew glue.Tableconstructors.